fix: add async effect for loading media - #492
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vercel
Bot
temporarily deployed
to
Preview – elements-demo-create-react-app
November 5, 2022 01:32
Inactive
Codecov Report
@@ Coverage Diff @@
## main #492 +/- ##
==========================================
+ Coverage 81.48% 81.55% +0.07%
==========================================
Files 45 45
Lines 6460 6464 +4
Branches 279 279
==========================================
+ Hits 5264 5272 +8
+ Misses 1194 1190 -4
Partials 2 2
|
gkatsev
reviewed
Nov 7, 2022
gkatsev
left a comment
gkatsev
left a comment
Contributor
There was a problem hiding this comment.
Seems like a reasonable approach.
vercel
Bot
temporarily deployed
to
Preview – elements-demo-create-react-app
November 7, 2022 20:13
Inactive
vercel
Bot
temporarily deployed
to
Preview – elements-demo-create-react-app
November 7, 2022 22:19
Inactive
vercel
Bot
temporarily deployed
to
Preview – elements-demo-create-react-app
November 7, 2022 22:36
Inactive
vercel
Bot
temporarily deployed
to
Preview – elements-demo-create-react-app
November 8, 2022 17:26
Inactive
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mediaElrequired in playback-core making some code and types easier.