fix: point pkgjson#browser at mjs build for webpack 4#191
Merged
Conversation
Browser field is mainly used to give a separate build for browsers than the one aimed at node.js that's in main. Since we currently target browsers and support node.js via our polyfill, we don't need a browser field. This also fixes an issue where older versions of webpack that don't know about the `exports` field will pick up `browser` over `main` or `module` and thus load in the iife build instead of the esm or commonjs build.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vercel
Bot
temporarily deployed
to
Preview – elements-demo-create-react-app
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 82.27% 82.29% +0.02%
==========================================
Files 35 35
Lines 3717 3717
Branches 135 136 +1
==========================================
+ Hits 3058 3059 +1
+ Misses 653 652 -1
Partials 6 6
|
vercel
Bot
temporarily deployed
to
Preview – elements-demo-create-react-app
gkatsev
changed the title
Contributor
Author
|
This PR should be squash merged. |
cjpillsbury
previously requested changes
Apr 21, 2022
Contributor
cjpillsbury
left a comment
cjpillsbury
left a comment
There was a problem hiding this comment.
Update mux-audio for consistency. Otherwise, 👍
vercel
Bot
temporarily deployed
to
Preview – elements-demo-create-react-app
luwes
approved these changes
Apr 21, 2022
Contributor
luwes
left a comment
luwes
left a comment
There was a problem hiding this comment.
LGTM, type is not needed anymore?
Contributor
Author
|
@luwes yeah, we don't really need type, especially since we don't have regular js files that have requires or imports and our main users are still bundlers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.