Fixed Chameleon schema support and added support for an edgecase with unqualified elements.#888
Merged
mvantellingen merged 1 commit intomvantellingen:masterfrom Dec 17, 2018
Merged
Conversation
… unqualified elements. This partially reverts the recently introduced support for chameleon schemas in the sense that it doesn't consider the targetNamespace of the WSDL as default namespace for the schema. Sadly it is valid (while ugly and not widely used) to have schemas with no namespace. Secondly this commits allows refering to those unqualified elements if an explicit empty <import/> (sic) is found. This seems to be mostly in line with https://www.w3.org/TR/2012/REC-xmlschema11-1-20120405/#src-resolve (if I read it correctly).
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
==========================================
+ Coverage 89.38% 89.38% +<.01%
==========================================
Files 65 65
Lines 4824 4825 +1
Branches 841 842 +1
==========================================
+ Hits 4312 4313 +1
Misses 331 331
Partials 181 181
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
==========================================
+ Coverage 89.38% 89.38% +<.01%
==========================================
Files 65 65
Lines 4824 4825 +1
Branches 841 842 +1
==========================================
+ Hits 4312 4313 +1
Misses 331 331
Partials 181 181
|
Owner
|
Thanks for the follow up. Reading the link you provided and since it seems to work for you i'm going to merge this :-) Thanks again for the work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially reverts the recently introduced support for chameleon
schemas in the sense that it doesn't consider the targetNamespace of the
WSDL as default namespace for the schema. Sadly it is valid (while ugly
and not widely used) to have schemas with no namespace.
Secondly this commits allows refering to those unqualified elements if
an explicit empty (sic) is found. This seems to be mostly in
line with https://www.w3.org/TR/2012/REC-xmlschema11-1-20120405/#src-resolve
(if I read it correctly).