Repository navigation
Replies: 1 comment 4 replies
|
Thanks, @smota, for asking before building, and for the clear write-up of today's behaviour and the proposal. As you describe it, the ask is for Pi agents to keep their configured effort, passed to Pi as |
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Short version. I use Pi seats to run models and providers that OpenRig doesn't support natively, with a different reasoning effort per seat. The model reaches Pi, but the effort is dropped. Would you take a PR that passes a Pi seat's effort to Pi, and lets
rig seat set-effortwork on Pi seats?What happens today
effort:on a Pi node is accepted and stored without a warning, but nothing passes it on.buildPiChildArgshas no thinking flag, and neither does the resume path.rig seat set-effortrefuses Pi seats with "reasoning effort applies to claude-code and codex seats only", andEffortRuntimeis"claude-code" | "codex".loworhighthat ran atmedium:model+effortsyntax,model: provider/id:high. Pi sets the thinking level from the suffix and records the model without it. Draft PR fix(daemon): Pi model-pin check reads a :<thinking level> suffix as Pi does #1403 supports that syntax in the model-pin check: a pin such asprovider/id:highis compared asprovider/id, so it no longer raises a false divergence notice. It also documents the suffix inrig-spec.md. fix(daemon): Pi model-pin check reads a :<thinking level> suffix as Pi does #1403 is stacked on fix(daemon): Pi model-pin check reads only the current runner's own record #1349 and will be marked ready once fix(daemon): Pi model-pin check reads only the current runner's own record #1349 lands.set-effortstill can't change it, and OpenRig doesn't report it.Proposal
Pi already has the flag:
pi --thinking <off|minimal|low|medium|high|xhigh|max>.--thinking <level>and forwards it to thepichild, on launch and on resume. With no effort set, nothing is passed and Pi keeps its default, as now.set-effort: addpitoEffortRuntime, with Pi's own levels. The saved choice applies at the next launch or resume, as it does for the other runtimes.--thinkingargument, and the observed effort fromthinkingLevelon Pi's assistant records. That fits the requested, saved, launched and observed values inseat-effort.ts.effortisn't a level Pi accepts, rather than dropping it silently.Out of scope: an effort-divergence notice, and OMP.
Questions
set-effortand reporting?noneand Pi usesoff. Should OpenRig translate between them, or accept only each runtime's own names?model: x/y:lowsuffix together witheffort: high. Should the explicit--thinkingwin, which is what Pi does, or should spec validation flag the conflict?I'd add unit tests for the runner and adapter arguments and a stub scenario for launch and resume, and describe the downstream effect, since launch and resume are on the arteries list.
All reactions