Client.py and error no 35 fix#2
Merged
mwalsh161 merged 4 commits intomwalsh161:masterfrom Jan 14, 2020
Merged
Conversation
mwalsh161
requested changes
Jan 12, 2020
Owner
mwalsh161
left a comment
mwalsh161
left a comment
There was a problem hiding this comment.
A few pretty minor changes. All print statements should be logger statements and all return values should be the actual values, not formatted strings.
| sock.sendall((urllib.parse.quote_plus(handshake)+'\n').encode()) | ||
|
|
||
| # Look for the response | ||
| resp = self.__recv(sock) |
Owner
There was a problem hiding this comment.
Might be worth checking that the response is the expected response.
Contributor
Author
There was a problem hiding this comment.
You mean checking if the response is "ack"?
I added a line "assert resp == 'ack', '%s does not exist' % module". Let me know if that works.
Owner
There was a problem hiding this comment.
Yep - except I would say a more general error; "Wan't able to get an acknowledgement from the server" (your error message makes an assumption that we don't need to make)
Contributor
Author
There was a problem hiding this comment.
Got it! Just changed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.