Add fixedHeader to DataTableOptions types, fix columnControl types#496
Add fixedHeader to DataTableOptions types, fix columnControl types#496kultura-luke wants to merge 3 commits intomwouts:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (90.78%) is below the target coverage (93.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
=======================================
Coverage 94.11% 94.11%
=======================================
Files 46 46
Lines 2530 2533 +3
=======================================
+ Hits 2381 2384 +3
Misses 149 149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @kultura-luke , thank you for opening this PR. Of course we can consider adding the fixed header extension, but a bit more work will be required. For instance we will have to add it to the I can take care of doing that, or alternatively, if you want to try it on your end, this is the documentation: https://mwouts.github.io/itables/custom_extensions.html#creating-a-custom-datatables-bundle |
|
That's strange because I swear it was working already, or perhaps I just got mixed up with the scrollY behaviour? I'm not entirely sure how to verify that it's working so if you could take that on that would be great 🙏 |
|
Yes will do! Cheers |
https://datatables.net/extensions/fixedheader/