feat: default filtering for Hodges algorithm#86
Merged
Conversation
…ackers - Enable T5-42 (range 5-42) spectral filtering by default for both Hodges and Simple trackers. - Update DataLoader to support in-memory xarray.DataArray to avoid redundant I/O after filtering. - Update HodgesDetector and SimpleDetector with get_xarray() and from_xarray() to process filtered data. - Fix TaperFilter and SphericalHarmonicFilter to dynamically map coordinate dimensions (latitude, longitude) from DataLoader.VAR_MAPPING. - Add mutually exclusive CLI flags --filter-range and --no-filter for flexible preprocessing control. - Ensure spectral filtering handles chunked dask arrays correctly in both serial and parallel backends.
- Add LMIN_DEFAULT=5 and LMAX_DEFAULT=42 to src/pystormtracker/hodges/constants.py. - Update HodgesTracker, SimpleTracker, and CLI to reference these centralized constants. - Ensure consistent default filtering behavior across all tracking algorithms and interfaces.
- Create src/pystormtracker/models/constants.py for project-wide defaults (Taper, Filter Range, Lifetime). - Update src/pystormtracker/hodges/constants.py to reference model-level constants. - Refactor HodgesTracker, SimpleTracker, and CLI to use centralized MIN_POINTS_DEFAULT and TAPER_DEFAULT. - Ensure consistent default behavior across all algorithms while maintaining algorithm-specific overrides.
mwyau
force-pushed
the
feat/default-filtering
branch
2 times, most recently
from
40094c8 to
b728aa4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 64.93% 61.31% -3.62%
==========================================
Files 21 22 +1
Lines 1885 2001 +116
==========================================
+ Hits 1224 1227 +3
- Misses 661 774 +113
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mwyau
force-pushed
the
feat/default-filtering
branch
from
b3410e2 to
7b57156
Compare
…ing for simple tracker to restore integration tests
mwyau
force-pushed
the
feat/default-filtering
branch
from
aa79d3f to
dc2e025
Compare
mwyau
force-pushed
the
feat/default-filtering
branch
2 times, most recently
from
5ed83d4 to
449b2be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.