Chart utils tweaks#479
Merged
Merged
Conversation
Contributor
|
|
jtanner
reviewed
Dec 14, 2016
Contributor
jtanner
left a comment
jtanner
left a comment
There was a problem hiding this comment.
Looks good, just one suggestion.
|
|
||
| const min = d3.min(this.props.data, d => { | ||
| return d.y; | ||
| }); |
Contributor
There was a problem hiding this comment.
What do you think about using the new shorthand style implicit returns to make these (and the ones in the other files) a tiny bit easier to read?
const max = d3.max(this.props.data, d => d.y);
const min = d3.min(this.props.data, d => d.y);
Contributor
Author
There was a problem hiding this comment.
yep, I'm good with that. I'll make the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were running into issues where the internal widgets axis ranges/ticks were not matching the mobile applications ranges/ticks. To solve the problem, I've ported the mobile c++ code over and revamped the Chart Utils file. Eventually I'll port more of the mobile teams code but for now this allows our line charts to be in parity with theirs.
This only has an effect on the TimeBasedLineChart in the open source but will also effect the internal NetWorth chart. I'll have screen shots in the internal PR showing how the graphs now look but the gist is that the y range and tick values are dialed in closer so that the line changes between points more dramatically.
@jmophoto Once this goes live you can start using it in Insight/Target as well.