Skip to content

Add localization to DateRangePicker#988

Merged
smstamm merged 5 commits intomasterfrom
sstamm/translate-date-picker
Oct 19, 2023
Merged

Add localization to DateRangePicker#988
smstamm merged 5 commits intomasterfrom
sstamm/translate-date-picker

Conversation

@smstamm
Copy link
Copy Markdown
Collaborator

@smstamm smstamm commented Oct 18, 2023

Issue: https://mxcom.atlassian.net/browse/MEW-452

Description

  • Adds a required getTranslation() function prop to allow the consumer to translate strings
image

Testing

This can't really be tested until it's integrated into Serenity, but once that's complete, the visible text, aria and dates should all be localized to Spanish (and French)

Comment thread src/components/DateRangePicker/SelectionPane.js
@csconly
Copy link
Copy Markdown
Collaborator

csconly commented Oct 19, 2023

This MR looks good to me

@smstamm smstamm merged commit ecef535 into master Oct 19, 2023
@smstamm smstamm deleted the sstamm/translate-date-picker branch October 19, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants