[ISSUE #5959]🚀Rename rocketmq-cli to rocketmq-store-inspect and update dependencies in Cargo files#5960
Conversation
…e dependencies in Cargo files
|
🔊@mxsm 🚀Thanks for your contribution🎉! 💡CodeRabbit(AI) will review your code first🔥! Note 🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥. |
WalkthroughThis pull request renames the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@rocketmq-tools/rocketmq-store-inspect/Cargo.toml`:
- Line 2: The package declares name = "rocketmq-store-inspect" but the published
binary is still named "rocketmq-cli-rust"; update the [[bin]] entry (the name
field currently set to "rocketmq-cli-rust") to "rocketmq-store-inspect" (and
adjust any corresponding path if necessary) so the crate and its binary match
the new crate name; ensure the binary name in Cargo.toml matches the package
name so publishing exposes the correct CLI.
| @@ -1,5 +1,5 @@ | |||
| [package] | |||
| name = "rocketmq-cli" | |||
| name = "rocketmq-store-inspect" | |||
There was a problem hiding this comment.
Rename the binary to match the new crate name.
The crate name now reflects "rocketmq-store-inspect", but the binary is still published as rocketmq-cli-rust (Line 25). This conflicts with the rename objective and leaves the old CLI name exposed to users.
🛠️ Proposed change
[[bin]]
-name = "rocketmq-cli-rust"
+name = "rocketmq-store-inspect"
path = "src/bin/rocketmq_cli.rs"🤖 Prompt for AI Agents
In `@rocketmq-tools/rocketmq-store-inspect/Cargo.toml` at line 2, The package
declares name = "rocketmq-store-inspect" but the published binary is still named
"rocketmq-cli-rust"; update the [[bin]] entry (the name field currently set to
"rocketmq-cli-rust") to "rocketmq-store-inspect" (and adjust any corresponding
path if necessary) so the crate and its binary match the new crate name; ensure
the binary name in Cargo.toml matches the package name so publishing exposes the
correct CLI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5960 +/- ##
==========================================
- Coverage 40.44% 40.43% -0.01%
==========================================
Files 854 854
Lines 119035 119035
==========================================
- Hits 48140 48137 -3
- Misses 70895 70898 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rocketmq-rust-bot
left a comment
There was a problem hiding this comment.
LGTM - All CI checks passed ✅
Which Issue(s) This PR Fixes(Closes)
Brief Description
How Did You Test This Change?
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.