Skip to content

[ISSUE #5959]🚀Rename rocketmq-cli to rocketmq-store-inspect and update dependencies in Cargo files#5960

Merged
rocketmq-rust-bot merged 1 commit intomainfrom
feat-5959
Jan 30, 2026
Merged

[ISSUE #5959]🚀Rename rocketmq-cli to rocketmq-store-inspect and update dependencies in Cargo files#5960
rocketmq-rust-bot merged 1 commit intomainfrom
feat-5959

Conversation

@mxsm
Copy link
Copy Markdown
Owner

@mxsm mxsm commented Jan 30, 2026

Which Issue(s) This PR Fixes(Closes)

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

  • Chores
    • Reorganized workspace configuration with centralized package metadata definitions.
    • Renamed store inspection tool package for improved clarity and consistency across the tool suite.

✏️ Tip: You can customize this high-level summary in your review settings.

@rocketmq-rust-bot
Copy link
Copy Markdown
Collaborator

🔊@mxsm 🚀Thanks for your contribution🎉!

💡CodeRabbit(AI) will review your code first🔥!

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

@rocketmq-rust-robot rocketmq-rust-robot added the feature🚀 Suggest an idea for this project. label Jan 30, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 30, 2026

Walkthrough

This pull request renames the rocketmq-cli crate to rocketmq-store-inspect and introduces a shared workspace package metadata section. The workspace declaration is expanded to include the new member, and import statements are updated to reference the renamed crate.

Changes

Cohort / File(s) Summary
Workspace Configuration
Cargo.toml
Added new workspace member rocketmq-tools/rocketmq-store-inspect and introduced [workspace.package] section with shared metadata (version, authors, edition, homepage, repository, license, keywords, categories, readme, description, rust-version).
Package Manifest
rocketmq-tools/rocketmq-store-inspect/Cargo.toml
Updated package name from rocketmq-cli to rocketmq-store-inspect; version and other metadata inherited from workspace package definition.
Binary Import Paths
rocketmq-tools/rocketmq-store-inspect/src/bin/rocketmq_cli.rs
Updated import statements to reference rocketmq_store_inspect crate instead of rocketmq_cli for Commands, RootCli, and print_content modules.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A little hop, a name so bright,
From "cli" to "inspect," what a sight!
With workspace packages all aligned,
The crate's new identity we find,
And imports dance to their new tune! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately reflects the main changes: renaming rocketmq-cli to rocketmq-store-inspect and updating Cargo dependencies across multiple files.
Linked Issues check ✅ Passed The changes successfully implement the stated objectives: the crate is renamed from rocketmq-cli to rocketmq-store-inspect, Cargo.toml files are updated, and import paths are corrected accordingly.
Out of Scope Changes check ✅ Passed All changes are directly related to the renaming objective: workspace member addition, Cargo.toml updates, package name change, and import path updates are all necessary for the refactoring.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-5959

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@rocketmq-tools/rocketmq-store-inspect/Cargo.toml`:
- Line 2: The package declares name = "rocketmq-store-inspect" but the published
binary is still named "rocketmq-cli-rust"; update the [[bin]] entry (the name
field currently set to "rocketmq-cli-rust") to "rocketmq-store-inspect" (and
adjust any corresponding path if necessary) so the crate and its binary match
the new crate name; ensure the binary name in Cargo.toml matches the package
name so publishing exposes the correct CLI.

@@ -1,5 +1,5 @@
[package]
name = "rocketmq-cli"
name = "rocketmq-store-inspect"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Rename the binary to match the new crate name.

The crate name now reflects "rocketmq-store-inspect", but the binary is still published as rocketmq-cli-rust (Line 25). This conflicts with the rename objective and leaves the old CLI name exposed to users.

🛠️ Proposed change
 [[bin]]
-name = "rocketmq-cli-rust"
+name = "rocketmq-store-inspect"
 path = "src/bin/rocketmq_cli.rs"
🤖 Prompt for AI Agents
In `@rocketmq-tools/rocketmq-store-inspect/Cargo.toml` at line 2, The package
declares name = "rocketmq-store-inspect" but the published binary is still named
"rocketmq-cli-rust"; update the [[bin]] entry (the name field currently set to
"rocketmq-cli-rust") to "rocketmq-store-inspect" (and adjust any corresponding
path if necessary) so the crate and its binary match the new crate name; ensure
the binary name in Cargo.toml matches the package name so publishing exposes the
correct CLI.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.43%. Comparing base (4e4b95a) to head (aceff89).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5960      +/-   ##
==========================================
- Coverage   40.44%   40.43%   -0.01%     
==========================================
  Files         854      854              
  Lines      119035   119035              
==========================================
- Hits        48140    48137       -3     
- Misses      70895    70898       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@rocketmq-rust-bot rocketmq-rust-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - All CI checks passed ✅

@rocketmq-rust-bot rocketmq-rust-bot merged commit 2fc9d37 into main Jan 30, 2026
20 checks passed
@rocketmq-rust-bot rocketmq-rust-bot added approved PR has approved and removed ready to review waiting-review waiting review this PR labels Jan 30, 2026
@mxsm mxsm deleted the feat-5959 branch February 22, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI review first Ai review pr first approved PR has approved auto merge feature🚀 Suggest an idea for this project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature🚀] Rename rocketmq-cli to rocketmq-store-inspect and update dependencies in Cargo files

3 participants