fix(tui): fix paste rendering for long/Unicode text#6
Merged
Conversation
Two issues fixed: 1. Unicode width mismatch: cursor_visual_row and compute_input_height used col+=1 per character, but ratatui wraps using actual Unicode widths. This caused scroll offset miscalculation, displaying garbled fragments after pasting text with wide/zero-width Unicode chars. Now uses unicode_width::UnicodeWidthChar for accurate column tracking. 2. Long single-line pastes: only multi-line pastes were collapsed into [Pasted text] markers. Long single-line pastes (>120 chars, common from web/PDF copy) were inlined, causing the cursor to escape the visible input area. Now collapses any paste over 120 chars. Also strips carriage returns (\r) from pasted text to normalize Windows-style line endings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Pasted text]markers, same as multi-line pastesTest plan
cargo clippy --workspace -- -D warningscargo test --workspace