Conversation
- Added overflow checks to unmanaged memory alignment functions `AlignUp`, `RoundUpToPowerOfTwo`, and `ArenaSegment.TryAlloc`. - Changed bounded exception types to `OutOfMemoryException` instead of `ArgumentOutOfRangeException`/`InvalidOperationException` for clarity and correctness when memory limits are exceeded. - Removed arbitrary `uint.MaxValue` limits from `ArenaList` and `ArenaPtrStack` buffer reallocation loops to permit operations over 4GB as long as `System.Buffer.MemoryCopy` can handle it safely. - Documented inline bitwise calculations with descriptions and comments. Co-authored-by: myarichuk <1473701+myarichuk@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
myarichuk
deleted the
fix/security-performance-improvements-13758527499366890796
branch
1 participant
This change implements the code review recommendations:
ArenaAllocator.csandArenaSegment.cs.ArenaList.csandArenaPtrStack.csto remove an artificial and restrictive 4GB byte count cap in allocations.InvalidOperationExceptionandArgumentOutOfRangeExceptionwithOutOfMemoryExceptionto follow .NET conventions for Out-Of-Memory scenarios.AlignUpandRoundUpToPowerOfTwoalongside inline comments explaining their behavior.PR created automatically by Jules for task 13758527499366890796 started by @myarichuk