Skip to content

Fix to close the ApplicationContext at assertion failing #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2017
Merged

Fix to close the ApplicationContext at assertion failing #232

merged 1 commit into from
Oct 6, 2017

Conversation

@kazuki43zoo
Copy link
Member

@kazuki43zoo kazuki43zoo commented Oct 6, 2017 •
edited
Loading

In the current implementation, if an assertion is failing, ApplicationContext does not close.

@kazuki43zoo kazuki43zoo merged commit 07bd7a8 into mybatis:master Oct 6, 2017
@kazuki43zoo kazuki43zoo deleted the close-applicationcontext branch October 6, 2017 01:06
@kazuki43zoo
Copy link
Member Author

kazuki43zoo commented Oct 6, 2017

I've backported to 1.3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kazuki43zoo