Skip to content

Conversation

@zaherhammoud
Copy link
Contributor

I have checked in the code related to the new proposed feature. Please review and let me know what you think.

Thanks,

Zaher Hammoud

@mnesarco
Copy link
Member

mnesarco commented Mar 4, 2013

This patch is very good. Thanks Zaher. I will apply it and then I will add a dependency to CGLIB for tests because of a known bug in mybatis-core-3.2.0 which mandates it at runtime. Once 3.2.1 is released I will remove the dependency again. Fix #1 and Close #2

mnesarco added a commit that referenced this pull request Mar 4, 2013
Code Fix for issue #1 (Add support for adding attributes to the Velocity context)
@mnesarco mnesarco merged commit 32de745 into mybatis:master Mar 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants