Skip to content

Automated native_function_invocation fixes#141

Closed
draco2003 wants to merge 1 commit intomyclabs:1.xfrom
wayfair-archive:fix_native_function_invocation
Closed

Automated native_function_invocation fixes#141
draco2003 wants to merge 1 commit intomyclabs:1.xfrom
wayfair-archive:fix_native_function_invocation

Conversation

@draco2003
Copy link
Copy Markdown

Reproduce with:
php php-cs-fixer --rules=native_function_invocation fix ./ --allow-risky=yes
(php-cs-fixer from : https://cs.symfony.com/)

Details:
https://veewee.github.io/blog/optimizing-php-performance-by-fq-function-calls/

@theofidry
Copy link
Copy Markdown
Collaborator

I would rather have import statement (use function/constant) which can be used for every function or constant and is more elegant rather than this one which just deals with opcache optimized functions

@draco2003
Copy link
Copy Markdown
Author

100% valid.
Would you pull in a PR using that method instead?

@theofidry
Copy link
Copy Markdown
Collaborator

theofidry commented Nov 15, 2019

Not sure what you mean by pulling in a PR, but I would welcome a PR with that method yes

@draco2003 draco2003 closed this Jun 1, 2021
@draco2003 draco2003 deleted the fix_native_function_invocation branch June 1, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants