Skip to content

Merge 1x into 2x#97

Closed
theofidry wants to merge 14 commits intomyclabs:2.xfrom
theofidry:merge-1x-into-2x
Closed

Merge 1x into 2x#97
theofidry wants to merge 14 commits intomyclabs:2.xfrom
theofidry:merge-1x-into-2x

Conversation

@theofidry
Copy link
Copy Markdown
Collaborator

No description provided.

theofidry and others added 14 commits October 15, 2017 19:33
I've did a review of the lib and did some cleanup, tweaks and added missing tests.

- Bumped minimal version to PHP 5.6.
- Fixed the PHPUnit config to exclude `deep_copy.php` from the coverage report
- Fixed a bug when using `useCloneMethod`: the old object was returned unchanged instead of returning the cloned object
- Make the coverage stricter by adding the `@covers` annotations
- Add missing tests
- Cosmetic cleanup
@theofidry theofidry closed this Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants