Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp/find_warnings.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,11 +208,11 @@ def _verify_includes(self, included_files):
def _verify_include_files_used(self, file_uses, included_files):
"""Find all #include files that are unnecessary."""
for include_file, use in file_uses.items():
if use != USES_DECLARATION:
if not use & USES_DECLARATION:
node, module = included_files[include_file]
if module.ast_list is not None:
msg = module.filename + ' does not need to be #included'
if use == USES_REFERENCE:
if use & USES_REFERENCE:
msg += '. Use a forward declaration instead'
self._add_warning(msg, node)

Expand All @@ -237,7 +237,7 @@ def _determine_uses(self, included_files, forward_declarations):
symbol_table = self.symbol_table

def _add_reference(name, namespace):
if not name in decl_uses and not None in namespace:
if not name in decl_uses and namespace and not None in namespace:
# TODO(nnorwitz): make less hacky, do real name lookup.
name = '::'.join(namespace) + '::' + name
if name in decl_uses:
Expand Down
7 changes: 7 additions & 0 deletions test/test.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#include "bar.h"

class Test
{
Test(const Bar& bar);
const Bar bar_;
};