Remove imports and variables #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 12, 2016 17:25
myint
requested changes
Dec 14, 2016
pyformat.py
Outdated
| help='use more aggressive formatters') | ||
| parser.add_argument('--remove-all-unused-imports', action='store_true', | ||
| help='remove all unused imports, not just standard library \ | ||
| (requires "aggresive")') |
Owner
There was a problem hiding this comment.
I try to avoid escaped newlines. Could you format that strings the way it is done below?
Contributor
Author
There was a problem hiding this comment.
It was just to reduce the line length - I've used another solution (which I now see you've used in other places).
| parser.add_argument('--remove-all-unused-imports', action='store_true', | ||
| help='remove all unused imports, not just standard library \ | ||
| (requires "aggresive")') | ||
| parser.add_argument('--remove-unused-variables', action='store_true', |
Owner
There was a problem hiding this comment.
I think it would be good to add a check to make sure that --aggressive is used. Otherwise, the user might wonder why it isn't working. Maybe something like:
if args.remove_unused_variables and not args.aggressive:
parser.error('--remove-unused-variables requires --aggressive')
Contributor
Author
There was a problem hiding this comment.
Yes indeed - good call.
Contributor
Author
|
Updated, and spelling mistakes corrected. |
myint
approved these changes
Dec 14, 2016
Owner
|
Thanks! |
Contributor
Author
|
Thanks for merging this, @myint. When do you release to PyPI? |
Owner
Contributor
Author
|
Brillo. Thank you and happy New Year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyformatdoes a lovely job of wrappingautoflaketo make changes recommended by a linter.autoflakeallows unused imports and variables to be removed, but the required flags aren't passed bypyformat.This adds the ability, in "aggressive" mode, to request that all unused imports (not just standard library) and variables be removed (by
autoflake).