feat: add configurable auto-verification for cherry-picked PRs#876
feat: add configurable auto-verification for cherry-picked PRs#876
Conversation
Added configuration option to control automatic verification of cherry-picked PRs, allowing users to disable auto-verification while maintaining backward compatibility (default: true). Configuration: - New `auto-verify-cherry-picked-prs` boolean config (default: true) - Available as global config and per-repository override - Cherry-picked PRs are detected via CHERRY_PICKED_LABEL_PREFIX label Changes: - Added auto_verify_cherry_picked_prs property to GithubWebhook class - Modified _process_verified_for_update_or_new_pull_request() to check: * If PR is cherry-picked (has CherryPicked label) * If auto-verify is disabled for cherry-picks * Skips auto-verification and sets status to queued if disabled - Added CHERRY_PICKED_LABEL_PREFIX import to pull_request_handler - Updated schema with new boolean field (global + repo level) - Updated example configs with usage examples - Added 2 comprehensive tests for both enabled/disabled scenarios - Updated README with cherry-pick configuration documentation - Updated schema validator to include new boolean field Backward Compatibility: - Default is true (maintains current behavior) - Cherry-picked PRs continue to be auto-verified by default - Users can opt-out per repository or globally Testing: - test_process_verified_cherry_picked_pr_auto_verify_enabled: Verifies default behavior - test_process_verified_cherry_picked_pr_auto_verify_disabled: Verifies disabled behavior - All 49 pull request handler tests pass
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
|
Caution Review failedThe pull request is closed. WalkthroughA new feature adds configurable auto-verification for cherry-picked PRs across the webhook server. The implementation introduces a boolean configuration flag Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes The changes follow a consistent pattern across multiple files (adding a new configuration flag), but span diverse file types (schema, config, implementation logic, tests, documentation) and introduce conditional logic in the pull request handler that warrants careful review. Possibly related issues
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/approve |
|
New container for ghcr.io/myk-org/github-webhook-server:latest published |
Added configuration option to control automatic verification of cherry-picked PRs, allowing users to disable auto-verification while maintaining backward compatibility (default: true).
Configuration:
auto-verify-cherry-picked-prsboolean config (default: true)Changes:
Backward Compatibility:
Testing:
Summary by CodeRabbit
New Features
Documentation