Fix ephemeral support #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quotes added in 08608da cause `ephemeral` to evaluate as false when `DISABLE_AUTO_UPDATE` was not set. This is explained in details in myoung34#249. This diff changes the logic to use an array where extra parameters are being added. When calling config.sh, the array is expanded. Testing: ../self_hosted_runner.env contains ``` EPHEMERAL=true ``` Before: https://gist.github.com/chantra/443dfaa60d964d938bcb1c020781ca00 we can see multiple jobs got scheduled on the runner After: https://gist.github.com/chantra/061dc471c63964c01a2e3733a53bd3ec we can see that when the job finished, the container shutdown. After with DISABLE_AUTO_UPDATE set: https://gist.github.com/chantra/df0102c7340b8f6bfd458ec56d9fa29c Also adding `set -x` before the call to `config.sh` revealed the arguments were correctly added. Fixes myoung34#249
Owner
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quotes added in 08608da cause
ephemeralto evaluate as false whenDISABLE_AUTO_UPDATEwas not set.This is explained in details in #249. This diff changes the logic to use an array where extra parameters are being added.
When calling config.sh, the array is expanded.
Testing:
../self_hosted_runner.env contains
Before: https://gist.github.com/chantra/443dfaa60d964d938bcb1c020781ca00 we can see multiple jobs got scheduled on the runner
After: https://gist.github.com/chantra/061dc471c63964c01a2e3733a53bd3ec we can see that when the job finished, the container shutdown.
After with DISABLE_AUTO_UPDATE set: https://gist.github.com/chantra/df0102c7340b8f6bfd458ec56d9fa29c
Also adding
set -xbefore the call toconfig.shrevealed the arguments were correctly added.Fixes #249