lint: use isort to normalize import order
#119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'll go push up a rebase of this today or tomorrow, since it's in conflict from recent merges. |
Note that `pylint` already depends on `isort`. Using it makes import sorting unambiguous and automatic. It's a little ambiguous whether it should be in the "lint" or "format" tox command, or another one altogether. It's included in "lint" here, because pylint already uses isort internally to catch coarse-grained "wrong-import-order" warnings.
Owner
|
Apologies for the massive delay in looking at this, and thanks for the changes! This looks great :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that
pylintalready depends onisort.Using it makes import sorting unambiguous and automatic, which helps reduce cognitive load merging various branches in this codebase.
It was a little ambiguous whether it should be in the "lint" or "format"
toxcommand, or another one altogether. It's included in "lint" here, because pylint already uses isort internally to catch coarse-grained "wrong-import-order" warnings.This also updates the
contributing.rstwhich referred to some incorrect tox commands.