Add HPET ACPI struct. #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add HPET struct for parsing in the HPET ACPI table. * Add GenericAddressStructure to the top-level acpi module for parsing GAS entries. * Add HPET find and parse routine in mythril_multiboot2.
Collaborator
|
Thanks for working on this! I haven't reviewed it yet, but I'm gonna close and re-open this so that (hopefully) the CI tests will run on it. I think I've got that fixed now. |
ALSchwalm
requested changes
May 23, 2020
Collaborator
ALSchwalm
left a comment
ALSchwalm
left a comment
There was a problem hiding this comment.
Awesome work! Thanks for being so thorough with the docs and test. Just a few minor things I'd like addressed before I merge.
* Add offsets module to acpi/mod.rs for GAS offsets. * Change order of bitwise operations when parsing HPET event_timer_block_id members. * Simplify 1-bit field to bool conversions. * Replace unwrapping match statements with ok_or_else() and unwrap_or_else().
* Add call to CPUID in GAS parser to see if we need to verify 32-bit addresses.
ALSchwalm
approved these changes
May 27, 2020
Collaborator
|
Thanks for tackling this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for parsing the ACPI HPET entry structure.
Fixes #53