Skip to content

core: improve readability of fmt::Debug output #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2020
Merged

core: improve readability of fmt::Debug output #67

merged 1 commit into from
Jun 15, 2020

Conversation

@dlrobertson
Copy link
Contributor

@dlrobertson dlrobertson commented Jun 13, 2020

Summary

  • format GustPhysAddr integer as hexidecimal
  • format HostPhysAddr integer as hexidecimal
  • format MemWriteRequest data bytes as hexidecimal

Example

[   5.383615] MYTHRIL-INFO: local apic read of addr = GuestPhysAddr(0xfee00280) (len=0x4)
[   5.386908] MYTHRIL-INFO: local apic write of addr = GuestPhysAddr(0xfee00370) (data=MemWriteRequest { data: [00, 00, 00, fe] })

core: improve readability of fmt::Debug output
335ef98 
 - format GustPhysAddr integer as hexidecimal
 - format HostPhysAddr integer as hexidecimal
 - format MemWriteRequest data bytes as hexidecimal
@dlrobertson dlrobertson requested a review from ALSchwalm June 13, 2020 15:27
@ALSchwalm
Copy link
Collaborator

ALSchwalm commented Jun 15, 2020

This looks good to me. Thanks!

@ALSchwalm ALSchwalm merged commit 2c87be3 into mythril-hypervisor:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ALSchwalm ALSchwalm Awaiting requested review from ALSchwalm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dlrobertson @ALSchwalm