Skip to content

Refact#68

Merged
myuron merged 3 commits intomainfrom
refact
Apr 2, 2026
Merged

Refact#68
myuron merged 3 commits intomainfrom
refact

Conversation

@myuron
Copy link
Copy Markdown
Owner

@myuron myuron commented Apr 2, 2026

Summary by CodeRabbit

  • New Features

    • Added Terraform and Terraform LSP support
    • Added vim-startuptime diagnostic tool
  • Style

    • Switched editor colorscheme to Tokyo Night
    • Removed several colorscheme plugins and the scrollbar plugin
  • Configuration

    • Adjusted workspace-to-monitor assignments
    • Updated terminal config linking
  • Performance

    • Converted many plugins to lazy-loading
  • Chores

    • Updated pinned Neovim plugin revisions

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 43eef918-53e4-41c1-81d6-025af369c7f4

📥 Commits

Reviewing files that changed from the base of the PR and between 15a5af2 and 6b60e7b.

📒 Files selected for processing (1)
  • nix/home-manager/common/default.nix

📝 Walkthrough

Walkthrough

Updated dotfiles: modified Home Manager package list and wezterm sourcing; added Terraform tools; reassigned nix-darwin aerospace workspaces; enabled tokyonight colorscheme; updated Neovim plugin pins; removed several color/theme plugins and scrollbar; and changed many plugins to lazy-load, plus added terraform_lsp to LSP servers.

Changes

Cohort / File(s) Summary
Nix Home Manager Packages
nix/home-manager/common/default.nix
Removed go from Go tools, added vim-startuptime to utilities, and introduced a Terraform tools section installing terraform and terraform-lsp.
Nix Wezterm Config
nix/home-manager/common/wezterm/default.nix
Replaced in-repo ./wezterm source with an out-of-store symlink via config.lib.file.mkOutOfStoreSymlink; removed recursive = true; module now explicitly accepts { config, ... }.
Nix Darwin Aerospace
nix/nix-darwin/aerospace/default.nix
Adjusted workspace-to-monitor-force-assignment: workspace "1" now → main; workspaces "6""10" moved to secondary; "2""5" remain main.
Neovim Colorscheme
nvim/init.lua
Activated tokyonight-night colorscheme (previous commented schemes left removed).
Neovim Plugin Removals
nvim/lua/plugins/catppuccin.lua, nvim/lua/plugins/kanagawa.lua, nvim/lua/plugins/nightfox.lua, nvim/lua/plugins/solarized-osaka.lua, nvim/lua/plugins/nvim-scrollbar.lua
Removed plugin specifications for catppuccin, kanagawa, nightfox, solarized-osaka, and nvim-scrollbar (files no longer return those plugin tables).
Neovim Lazy Loading Updates
nvim/lua/plugins/mason.lua, nvim/lua/plugins/mini.lua, nvim/lua/plugins/nvim-cmp.lua, nvim/lua/plugins/nvim-dap-go.lua, nvim/lua/plugins/nvim-treesitter.lua, nvim/lua/plugins/vim-prisma.lua
Added or changed lazy = true flags to convert these plugins to lazy-loading.
Neovim LSP Configuration
nvim/lua/plugins/nvim-lspconfig.lua
Set plugin to lazy = true and added terraform_lsp to enabled LSP servers.
Neovim Plugin Lock File
nvim/lazy-lock.json
Updated pinned commit hashes for multiple plugins (LuaSnip, catppuccin, gitsigns, mini, nvim-cmp, nvim-dap, nvim-dap-ui, nvim-lspconfig, nvim-treesitter, nvim-web-devicons, snacks, tokyonight).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • fish #62 — modifies the same Home Manager package list in nix/home-manager/common/default.nix.
  • add:settings #37 — adjusts wezterm/Home Manager sourcing and module shape, related to the wezterm symlink change.
  • add:aerospace #31 — updates the same nix-darwin aerospace workspace-to-monitor force-assignment mappings.

Poem

🐰 I hop through configs, tidy and spry,
Tokyonight blooms as old themes say goodbye,
Terraform seeds planted in Nix's field,
Workspaces leap where monitors yield,
Lazy plugins stretch, then nimbly fly.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Refact' is vague and generic, failing to convey what specific changes are included in this substantial refactoring PR. Replace with a descriptive title summarizing the main changes, such as 'Switch Neovim colorscheme to tokyonight and lazy-load multiple plugins' or 'Refactor Neovim configuration and Home Manager packages'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refact

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@myuron myuron merged commit 2e6b38c into main Apr 2, 2026
1 check failed
@myuron myuron deleted the refact branch April 2, 2026 09:53
@coderabbitai coderabbitai Bot mentioned this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant