Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (2)
nix/home-manager/common/symlink/default.nix (1)
1-9: LGTM — consider hoisting the dotfiles path for reuse.The module correctly uses
mkOutOfStoreSymlinkto link~/.config/ghosttyto the in-repoghostty/directory. If you plan to add more out-of-store symlinks later (e.g., for other app configs), a small refactor avoids repeating the ghq path:♻️ Optional refactor
{ config, ...}: let inherit (config.lib.file) mkOutOfStoreSymlink; + dotfiles = "${config.home.homeDirectory}/src/github.com/myuron/dotfiles"; in { home.file.".config/ghostty" = { - source = mkOutOfStoreSymlink "${config.home.homeDirectory}/src/github.com/myuron/dotfiles/ghostty"; + source = mkOutOfStoreSymlink "${dotfiles}/ghostty"; }; }Note: If the repo isn't cloned at that exact path, the symlink will dangle silently after activation — worth keeping in mind when bootstrapping a new machine.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@nix/home-manager/common/symlink/default.nix` around lines 1 - 9, Hoist the hard-coded repo path into a reusable variable and reference it when creating out-of-store symlinks: introduce a local like dotfilesDir = "${config.home.homeDirectory}/src/github.com/myuron/dotfiles"; then replace the inline path in the home.file.".config/ghostty" source (which currently uses mkOutOfStoreSymlink and config.home.homeDirectory) with mkOutOfStoreSymlink "${dotfilesDir}/ghostty" so future entries can reuse dotfilesDir for other symlinks.flake.nix (1)
40-42: Declarelazycwlto follow the samenixpkgsas the flake.
lazycwlhas anixpkgsinput but unlikeclaude-code-overlay(line 35), does not pin it to your flake'snixpkgs. This allowslazycwlto pull its own transitivenixpkgs, which can bloat the lock file and cause overlays to be built against a different nixpkgs version than your pinned one.♻️ Suggested change
lazycwl = { url = "github:myuron/lazycwl"; + inputs.nixpkgs.follows = "nixpkgs"; };🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@flake.nix` around lines 40 - 42, The lazycwl flake input currently omits following the repository's pinned nixpkgs; update the lazycwl input declaration so it follows the same nixpkgs as this flake (make lazycwl's input include inputs.nixpkgs.follows = "nixpkgs") to prevent it pulling its own transitive nixpkgs and ensure overlays build against the pinned version; locate the lazycwl input block in flake.nix (the lazycwl = { url = "github:myuron/lazycwl"; } entry) and add the follows directive to reference the flake's nixpkgs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@nvim/lua/configs/keymap.lua`:
- Around line 125-127: The keybindings using the MdRender commands will raise
E492 because md-render.nvim's setup() is never invoked; fix by ensuring the
plugin's setup is called in the plugin spec (nvim/lua/plugins/md-render.lua) or
lazy-load the setup before mapping: update the plugin config to call
require("md-render").setup(...) or add a protected loader around the keymaps
(reference the keymap calls keymap("n", "<leader>mp", "<cmd>MdRender<CR>"),
keymap("n", "<leader>mt", "<cmd>MdRenderTab<CR>"), keymap("n", "<leader>md",
"<cmd>MdRenderDemo<CR>") ) so the plugin is initialized before those commands
are registered.
- Line 117: There's a small typo in the section comment "-- Formag" in
nvim/lua/configs/keymap.lua; update that comment to read "-- Format" so the
section header accurately reflects the formatting keymaps (look for the comment
string "Formag" near the format/formatting keymap block to replace it).
- Line 123: The mapping keymap("n", "<leader>sm", "<cmd>RenderMarkdown
toggle<CR>", ...) refers to the RenderMarkdown command from
MeanderingProgrammer/render-markdown.nvim which is not installed; either add the
plugin spec for "MeanderingProgrammer/render-markdown.nvim" (with dependency
"nvim-tree/nvim-web-devicons" and ft = {"markdown"}) into your plugin specs so
RenderMarkdown is available, or remove/change the mapping in
nvim/lua/configs/keymap.lua to point to an installed plugin/command; locate the
mapping by the keymap call referencing "<leader>sm" and update accordingly.
- Line 84: The keymap for normal mode using keymap("n", "gr", function()
lsp.references() end, ...) has an incorrect description "Hover Doc"; update the
desc to accurately reflect the action (e.g., "LSP References" or "Show
References") so which-key and command history display the correct label for the
mapping referencing lsp.references(); adjust the desc string inside the same
keymap call.
In `@nvim/lua/plugins/md-render.lua`:
- Around line 1-8: The plugin spec currently doesn't call md-render.nvim's setup
so the ex-commands (MdRender, MdRenderTab, MdRenderDemo) are never registered;
update the returned table to make the plugin lazy-load on those commands and run
its setup: add a cmd = {"MdRender","MdRenderTab","MdRenderDemo"} entry to
trigger loading, and provide either a config = function()
require("md-render").setup() end or an opts = {} (so lazy.nvim calls setup) to
run setup when loaded; keep existing dependencies intact.
---
Nitpick comments:
In `@flake.nix`:
- Around line 40-42: The lazycwl flake input currently omits following the
repository's pinned nixpkgs; update the lazycwl input declaration so it follows
the same nixpkgs as this flake (make lazycwl's input include
inputs.nixpkgs.follows = "nixpkgs") to prevent it pulling its own transitive
nixpkgs and ensure overlays build against the pinned version; locate the lazycwl
input block in flake.nix (the lazycwl = { url = "github:myuron/lazycwl"; }
entry) and add the follows directive to reference the flake's nixpkgs.
In `@nix/home-manager/common/symlink/default.nix`:
- Around line 1-9: Hoist the hard-coded repo path into a reusable variable and
reference it when creating out-of-store symlinks: introduce a local like
dotfilesDir = "${config.home.homeDirectory}/src/github.com/myuron/dotfiles";
then replace the inline path in the home.file.".config/ghostty" source (which
currently uses mkOutOfStoreSymlink and config.home.homeDirectory) with
mkOutOfStoreSymlink "${dotfilesDir}/ghostty" so future entries can reuse
dotfilesDir for other symlinks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4569a261-7efd-4ee8-b942-dddba8e0ed80
⛔ Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
📒 Files selected for processing (10)
flake.nixghostty/confignix/home-manager/common/default.nixnix/home-manager/common/fish/default.nixnix/home-manager/common/symlink/default.nixnix/nix-darwin/default.nixnvim/lazy-lock.jsonnvim/lua/configs/keymap.luanvim/lua/plugins/md-render.luanvim/lua/plugins/nvim-cmp.lua
| -- Hover Document | ||
| keymap("n", "<leader>lh", function() lsp.hover() end, { desc = "Hover Doc" }) | ||
| keymap("n", "K", function() lsp.hover() end, { desc = "Hover Doc" }) | ||
| keymap("n", "gr", function() lsp.references() end, { desc = "Hover Doc" }) |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Neovim 0.11 default LSP keymap gr references
💡 Result:
In Neovim 0.11, the default LSP keymaps use a "gr" prefix for several common actions. These are global defaults created unconditionally when Neovim starts: - grr (Normal mode): vim.lsp.buf.references - Find references to the symbol under the cursor. - gra (Normal and Visual mode): vim.lsp.buf.code_action - Perform code actions. - grn (Normal mode): vim.lsp.buf.rename - Rename the symbol under the cursor. - gri (Normal mode): vim.lsp.buf.implementation - Go to implementation. - grt (Normal mode): vim.lsp.buf.type_definition - Go to type definition. - grx (Normal mode): vim.lsp.codelens.run - Run code lens. These can be viewed in the official documentation with :help lsp-defaults or :help grr, etc. They do not override existing user mappings. To disable, use vim.keymap.del or handle in LspAttach autocmd.
Citations:
- 1: https://neovim.io/doc/user/lsp/
- 2: Change LSP Keybindings to Match the Default
grBindings Introduced in Neovim 0.11 nvim-lua/kickstart.nvim#1427 - 3: feat(defaults): add LSP default mappings (again) neovim/neovim#28650
- 4: https://neovim.io/doc/user/news-0.11/
Fix incorrect desc for LSP references mapping.
The gr keybinding calls lsp.references() but the description is labeled "Hover Doc". This will surface incorrectly in which-key and command history.
✏️ Proposed fix
-keymap("n", "gr", function() lsp.references() end, { desc = "Hover Doc" })
+keymap("n", "gr", function() lsp.references() end, { desc = "References" })📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| keymap("n", "gr", function() lsp.references() end, { desc = "Hover Doc" }) | |
| keymap("n", "gr", function() lsp.references() end, { desc = "References" }) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@nvim/lua/configs/keymap.lua` at line 84, The keymap for normal mode using
keymap("n", "gr", function() lsp.references() end, ...) has an incorrect
description "Hover Doc"; update the desc to accurately reflect the action (e.g.,
"LSP References" or "Show References") so which-key and command history display
the correct label for the mapping referencing lsp.references(); adjust the desc
string inside the same keymap call.
| keymap("n", "<leader>la", function() lsp.code_action() end, { desc = "Code Action" }) | ||
|
|
||
| -- Format | ||
| -- Formag |
There was a problem hiding this comment.
Nit: typo in section comment — Formag → Format.
✏️ Proposed fix
--- Formag
+-- Format📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| -- Formag | |
| -- Format |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@nvim/lua/configs/keymap.lua` at line 117, There's a small typo in the section
comment "-- Formag" in nvim/lua/configs/keymap.lua; update that comment to read
"-- Format" so the section header accurately reflects the formatting keymaps
(look for the comment string "Formag" near the format/formatting keymap block to
replace it).
| -- ------------------------------ | ||
| -- Misc | ||
| -- ------------------------------ | ||
| keymap("n", "<leader>sm", "<cmd>RenderMarkdown toggle<CR>", { desc = "Toggle Render Markdown" }) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Confirm no other plugin in the repo registers a `RenderMarkdown` ex-command.
rg -nP --type=lua -C2 'render-?markdown\.nvim|RenderMarkdown'
fd -t f -e lua . nvim/lua/plugins | xargs rg -nP 'render-?markdown'Repository: myuron/dotfiles
Length of output: 408
<leader>sm references a command that isn't provided by any plugin in this config.
:RenderMarkdown toggle is exposed by MeanderingProgrammer/render-markdown.nvim, not by delphinus/md-render.nvim. There is no render-markdown.nvim entry in nvim/lazy-lock.json and no matching plugin spec under nvim/lua/plugins/, so pressing <leader>sm will error with E492: Not an editor command: RenderMarkdown.
Either add the plugin or drop the mapping:
🛠 Option A — add the plugin spec
-- nvim/lua/plugins/render-markdown.lua
return {
"MeanderingProgrammer/render-markdown.nvim",
dependencies = { "nvim-tree/nvim-web-devicons" },
ft = { "markdown" },
opts = {},
}🛠 Option B — remove the mapping
-keymap("n", "<leader>sm", "<cmd>RenderMarkdown toggle<CR>", { desc = "Toggle Render Markdown" })📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| keymap("n", "<leader>sm", "<cmd>RenderMarkdown toggle<CR>", { desc = "Toggle Render Markdown" }) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@nvim/lua/configs/keymap.lua` at line 123, The mapping keymap("n",
"<leader>sm", "<cmd>RenderMarkdown toggle<CR>", ...) refers to the
RenderMarkdown command from MeanderingProgrammer/render-markdown.nvim which is
not installed; either add the plugin spec for
"MeanderingProgrammer/render-markdown.nvim" (with dependency
"nvim-tree/nvim-web-devicons" and ft = {"markdown"}) into your plugin specs so
RenderMarkdown is available, or remove/change the mapping in
nvim/lua/configs/keymap.lua to point to an installed plugin/command; locate the
mapping by the keymap call referencing "<leader>sm" and update accordingly.
| keymap("n", "<leader>mp", "<cmd>MdRender<CR>") | ||
| keymap("n", "<leader>mt", "<cmd>MdRenderTab<CR>") | ||
| keymap("n", "<leader>md", "<cmd>MdRenderDemo<CR>") |
There was a problem hiding this comment.
MdRender* commands depend on md-render.nvim setup that is never invoked — see comment on nvim/lua/plugins/md-render.lua.
These three keybindings will fail with E492 unless the plugin's setup() runs. The root-cause fix is in the plugin spec (missing config/opts); flagging here so both are addressed together.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@nvim/lua/configs/keymap.lua` around lines 125 - 127, The keybindings using
the MdRender commands will raise E492 because md-render.nvim's setup() is never
invoked; fix by ensuring the plugin's setup is called in the plugin spec
(nvim/lua/plugins/md-render.lua) or lazy-load the setup before mapping: update
the plugin config to call require("md-render").setup(...) or add a protected
loader around the keymaps (reference the keymap calls keymap("n", "<leader>mp",
"<cmd>MdRender<CR>"), keymap("n", "<leader>mt", "<cmd>MdRenderTab<CR>"),
keymap("n", "<leader>md", "<cmd>MdRenderDemo<CR>") ) so the plugin is
initialized before those commands are registered.
| return { | ||
| "delphinus/md-render.nvim", | ||
| version = "*", | ||
| dependencies = { | ||
| { "nvim-tree/nvim-web-devicons", version = "*" }, | ||
| { "delphinus/budoux.lua", version = "*" }, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Plugin spec never triggers setup(), so MdRender* commands won't be registered.
lazy.nvim only calls a plugin's setup() when either opts or a config function is present on the spec. This spec has neither, so although md-render.nvim is installed and pinned in nvim/lazy-lock.json, the MdRender, MdRenderTab, and MdRenderDemo ex-commands used in nvim/lua/configs/keymap.lua (lines 125–127) are never created.
🛠 Proposed fix — trigger setup and load lazily
return {
"delphinus/md-render.nvim",
version = "*",
dependencies = {
{ "nvim-tree/nvim-web-devicons", version = "*" },
{ "delphinus/budoux.lua", version = "*" },
},
+ cmd = { "MdRender", "MdRenderTab", "MdRenderDemo" },
+ ft = { "markdown" },
+ opts = {},
}delphinus md-render.nvim setup commands MdRender MdRenderTab
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@nvim/lua/plugins/md-render.lua` around lines 1 - 8, The plugin spec currently
doesn't call md-render.nvim's setup so the ex-commands (MdRender, MdRenderTab,
MdRenderDemo) are never registered; update the returned table to make the plugin
lazy-load on those commands and run its setup: add a cmd =
{"MdRender","MdRenderTab","MdRenderDemo"} entry to trigger loading, and provide
either a config = function() require("md-render").setup() end or an opts = {}
(so lazy.nvim calls setup) to run setup when loaded; keep existing dependencies
intact.
…OfStoreSymlink home-manager の files: handle overlapping file targets 変更で .config/nvim 配下の処理順が変わり、シンボリックリンク先を realpath が $HOME 外に解決して home-manager-files のビルドが失敗していた。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 participant
Summary by CodeRabbit
New Features
Chores
Chores