Add package type verification script, update exports, and enhance workflows#368
Add package type verification script, update exports, and enhance workflows#368
Conversation
…ce workflows - Introduced `verify-package-types.mjs` to validate subpath exports and declarations. - Enhanced `package.json` exports with type paths for improved type safety. - Updated `vite.config.ts` to generate declaration entrypoints. - Integrated package-type verification into CI workflows and contributor documentation.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Pull request overview
This PR strengthens the Vue package’s published TypeScript surface by generating explicit declaration entrypoints for each exported subpath and adding a CI smoke test that validates the packed artifact’s declarations match package.json exports.
Changes:
- Added
verify-package-types.mjsto pack the Vue workspace and smoke-test published.d.tssubpath exports viavue-tsc. - Updated
package.jsonexportsto include explicittypespaths for.and subpath entrypoints. - Updated the Vite build to generate declaration entrypoint stubs and integrated the verification into CI and contributor docs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
vue/vite.config.ts |
Adds multi-entry library config constants and a build plugin that writes dist/*.d.ts entrypoints; adjusts vite-plugin-dts settings. |
vue/scripts/verify-package-types.mjs |
New script that packs the workspace, inspects declarations, and runs a vue-tsc smoke test against the installed tarball. |
vue/package.json |
Adds exports.*.types mappings and a new test:package-types script. |
vue/README.md |
Documents the new test:package-types command. |
vue/CONTRIBUTE.md |
Adds the new package-types check to contributor quality gates guidance. |
.github/workflows/vue.yml |
Adds a new CI job to run npm run test:package-types. |
.github/workflows/release.yml |
Adds a pre-publish step to verify packaged type declarations during release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Fix a misconfiguration of exports that led to bugs using the network layer
verify-package-types.mjsto validate subpath exports and declarations.package.jsonexports with type paths for improved type safety.vite.config.tsto generate declaration entrypoints.