feat: Make node_id in ClientConnected optional #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason we can't get the node_id for 0rtt connections. Blobs does not use 0rtt, but it might in the future. So we don't have the node_id in all cases when we need to create a ClientConnected event. See n0-computer/iroh#3123
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/148/docs/iroh_blobs/ Last updated: 2025-09-16T07:23:42Z |
flub
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason we can't get the node_id for 0rtt connections. Blobs does not use 0rtt, but it might in the future. So we don't have the node_id in all cases when we need to create a ClientConnected event.
See n0-computer/iroh#3123
Breaking Changes
No additional breaking changes compared to the last published version, since the ClientConnected event is new.
Notes & open questions
Question: should we add some more stuff to the ClientConnected event since we might not have the node id? Socket addrs or something?
Change checklist