feat(MemStore)!: expose garbage collection #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/177/docs/iroh_blobs/ Last updated: 2025-10-06T15:19:09Z |
b5
changed the title
MemStore
|
😊 I guess I thought gc for mem was working since I had tests for it... Ah, this is where the stray file form the other PR comes from! |
|
Looks fine other than fmt. The public API change is so inconsequential that I am tempted to call this "no change"... A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented. Options is no longer RefUnwindSafe, nobody cares... |
rklaehn
force-pushed
the
b5/memstore_gc
branch
from
9a0777e to
3668422
Compare
rklaehn
force-pushed
the
b5/memstore_gc
branch
from
da7145c to
d112bae
Compare
4 tasks
Frando
added a commit
that referenced
this pull request
Nov 4, 2025
## Description #177 made GC work with the MemStore as well. However the types needed for configuring that are still behind the `fs-store` feature. This PR exposes these types independent of feature flags. ## Breaking Changes Moved: `iroh_blobs::store::fs::options::{GcConfig, ProtectOutcome, ProtectCb}` are now `iroh_blobs::store::{GcConfig, ProtectOutcome, ProtectCb}` ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was a smaller change than expected.
gc_smoke_memtest, so we know GC works with a memstorestore::mem::Optionswas already defined, just empty. I've added a publicgc: Option<GcConfig>fieldMemStore::newto callMemStore::new_with_optsto expose providing custom GC optionsBreaking Changes
None.
Notes & open questions
I haven't actually ensured that
MemStore::new_with_optsworks & is publically exposed. Should add a test for thatChange checklist