deps: Fix deps to actually work, not just compile, in wasm-browser #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rklaehn
changed the title
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/201/docs/iroh_blobs/ Last updated: 2025-12-04T09:52:12Z |
Collaborator
Author
|
@b5 I closed your PR and redid it because there were too many conflicts now that blobs is using n0-error. I hope I got all places where std::time::{Time, Duration, Instant} were used, but I don't really know how to check that this actually works... |
dignifiedquire
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While this will currently compile to wasm, when running in the browser, any reference to
std::timewill explode with unsupported platform errors, this fixes that.Breaking Changes
Notes & open questions
Note: replaces #194 which is obsolete due to the change to n0-error
Change checklist