tutorial: outdated SecretKey::generate since 0.93

[qykr]

Describe the bug
SecretKey::generate still requires the parameter csprng to implement CryptoRng, but this breaks for OsRng in rand@0.9 even though an official tutorial shows passing OsRng directly. In rand@0.8, it worked because OsRng implemented CryptoRng, but now it only implements TryCryptoRng. Looking at previous issues and PRs, I can see that there has been work on upgrading rand to 0.9, so either the tutorial should be updated or this should be treated as a bug and should be fixed.

OsRng for rand@0.9
OsRng for rand@0.8
PR for upgrading to rand@0.9 as cited in the 0.93.0 announcement

Expected behavior
It should compile and work as expected as shown in the tutorial

Iroh

iroh v0.93.2
├── iroh feature "default"
│   └── iron-gossip-cli v0.1.0 (/Users/<name>/Projects/iron-gossip-cli)
│       └── iron-gossip-cli feature "default" (command-line)
└── iroh feature "metrics"
    └── iroh feature "default" (*)

Platform(s)
all

Also, this is my first issue, so please let me know if I'm doing anything wrong or if I can improve on anything.

[dignifiedquire]

Thanks for the issue, the website is in urgent need of updates, so I will move this there.
The tdlr is I would recommend passing &mut rand::rng() in the latest versions, or if you really want to use OsRng you can use unwrap_err: &mut OsRng.unwrap_err()

[qykr]

Thanks for the issue, the website is in urgent need of updates, so I will move this there. The tdlr is I would recommend passing &mut rand::rng() in the latest versions, or if you really want to use OsRng you can use unwrap_err: &mut OsRng.unwrap_err()

In the official docs, I see
impl<R: CryptoRng + ?Sized> TryCryptoRng for R {}

Would it be a good idea to simply make csprng: TryCryptoRng instead of csprng: CryptoRng + ?Sized

[qykr]

So I looked a little further and found that SecretKey is basically a wrapper around ed25519_dalek::SigningKey, which requires impl CryptoRng, so it's not something that can be fixed immediately

[matheus23]

The website tutorial was updated in #412 by @Anonymous-AAA