feat!: Switch from anyhow and thiserror to n0-error
#78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheus23
commented
Nov 4, 2025
Cargo.toml
Outdated
Comment on lines
113
to
115
|
|
||
| [patch.crates-io] | ||
| iroh = { git = "https://github.com/n0-computer/iroh.git", branch = "main" } |
Member
Author
There was a problem hiding this comment.
I think iroh needs to be released before this can be merged.
Frando
reviewed
Nov 4, 2025
irpc-iroh/examples/0rtt.rs
Outdated
| info!("0-RTT not possible from our side"); | ||
| let fut: future::Boxed<bool> = Box::pin(async { true }); | ||
| let conn = connecting.await?; | ||
| let conn = connecting.await.anyerr()?; |
Member
There was a problem hiding this comment.
Once n0-computer/iroh#3556 is merged the anyerr can be removed.
Frando
reviewed
Nov 4, 2025
Frando
reviewed
Nov 4, 2025
4 tasks
Frando
approved these changes
Nov 4, 2025
Frando
force-pushed
the
matheus23/irpc-n0-error
branch
from
cbd2c2b to
d8b213b
Compare
Member
Author
|
One pending thing to figure out here is whether we should revert the example code to using I think so, I'll try to make this change later today. |
rklaehn
force-pushed
the
matheus23/irpc-n0-error
branch
3 times, most recently
from
dd759aa to
e26f93f
Compare
anyhow is a dev dependency of both irpc and irpc-iroh because dev deps are included in examples.
rklaehn
force-pushed
the
matheus23/irpc-n0-error
branch
from
e26f93f to
79adfbb
Compare
Based on #81 With the 0rtt status being accessible from the connection directly, we can just move this into the `RemoteConnection` abstraction, making working with 0rtt requests simpler for implementors (see changes to the 0rtt example!).
Member
|
note: rudi pushed changing the examples back to anyhow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches all uses of
thiserrorinirpcandirpc-irohto usen0-errorRemoves the
anyhowdependency and replaces all use of it withAnyError/n0-errorSelf-review