Skip to content

fix: Don't allow sending path status frames on non-multipath connections#191

Merged
matheus23 merged 6 commits intomain-irohfrom
matheus23/fix-path-status-send
Dec 2, 2025
Merged

fix: Don't allow sending path status frames on non-multipath connections#191
matheus23 merged 6 commits intomain-irohfrom
matheus23/fix-path-status-send

Conversation

@matheus23
Copy link
Member

@matheus23 matheus23 commented Dec 1, 2025

No description provided.

@matheus23 matheus23 self-assigned this Dec 1, 2025
@n0bot n0bot bot added this to iroh Dec 1, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Dec 1, 2025
@matheus23 matheus23 force-pushed the matheus23/fix-path-status-send branch from d3126e7 to ca1b4ff Compare December 1, 2025 17:36
@dignifiedquire
Copy link
Contributor

needs update/rebase

Copy link
Collaborator

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 on all the renames to be fair. But it seems I'm alone on this 🤷

path_id: PathId,
timeout: Option<Duration>,
) -> Result<Option<Duration>, ClosedPath> {
) -> Result<Option<Duration>, NotOpen> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, should this error if multipath is not negotiated? I guess it's not wrong right now, but a little weird. Let's leave it for now maybe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that causes something to be sent over the wire? If so, then yes this should return an error if multipath is not negotiated.
If not, then I think that's optional.

@flub
Copy link
Collaborator

flub commented Dec 2, 2025

-1 on all the renames to be fair. But it seems I'm alone on this 🤷

Let me expand on this. I think the state of a path is not very clearly defined in the multipath draft, and therefore folks (including me) do not have a clear view of the states. Essentially at any point it is valid to send a packet for a path_id as long as the path_id is below the current max path ID and not yet abandoned. That means paths don't have a clearly defined "now it's open" state. A non-abandoned path below the current max path ID is always kinda open. And you can get path errors on paths you didn't know had been "active" yet.

@matheus23
Copy link
Member Author

The main goal of this PR is to get the bug fix in. The renames just pollute the PR (I introduced them originally because I ended up creating a conflicting PathError, and needed two separate names).

Let's get this reviewed for the bug fix not for the renames.

@matheus23 matheus23 enabled auto-merge December 2, 2025 11:24
@matheus23 matheus23 merged commit 1b83e4f into main-iroh Dec 2, 2025
17 of 28 checks passed
@matheus23 matheus23 deleted the matheus23/fix-path-status-send branch December 2, 2025 11:27
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Dec 2, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.38%. Comparing base (a1cc539) to head (656f144).
⚠️ Report is 7 commits behind head on main-iroh.

Files with missing lines Patch % Lines
quinn-proto/src/connection/mod.rs 85.71% 1 Missing ⚠️
quinn/src/path.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           main-iroh     #191      +/-   ##
=============================================
- Coverage      76.38%   76.38%   -0.01%     
=============================================
  Files             83       83              
  Lines          22281    22286       +5     
=============================================
+ Hits           17020    17023       +3     
- Misses          5261     5263       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants