test(proto): Stop driving the connection before a path idle timer fires#557
Merged
test(proto): Stop driving the connection before a path idle timer fires#557
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/557/docs/noq/ Last updated: 2026-04-02T08:39:25Z |
Performance Comparison Report
|
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5964.7 Mbps | 7962.6 Mbps | -25.1% | 96.8% / 98.5% |
| medium-concurrent | 5459.0 Mbps | 7457.4 Mbps | -26.8% | 96.6% / 98.1% |
| medium-single | 4367.8 Mbps | 4292.7 Mbps | +1.7% | 95.5% / 98.1% |
| small-concurrent | 4002.7 Mbps | 4891.2 Mbps | -18.2% | 97.1% / 99.5% |
| small-single | 3688.4 Mbps | 4383.3 Mbps | -15.9% | 97.0% / 100.0% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3184.6 Mbps | 4023.3 Mbps | -20.8% |
| lan | 782.4 Mbps | 810.4 Mbps | -3.5% |
| lossy | 69.9 Mbps | 69.8 Mbps | ~0% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 18.8% slower on average
flub
approved these changes
Apr 2, 2026
Collaborator
flub
left a comment
flub
left a comment
There was a problem hiding this comment.
Oh nice, I was fearing this would result in new proptest failures. But great we can fix this without too much churn.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
|
git checkouts failed, thanks github |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is more in line with what
is_idleis doing withConnIdleas well, and in the future once we handle #518 this is even more important, as the tests expect that callingpair.drive()doesn't run the connection till the idle timeout.Breaking Changes
Test changes only.