fix: bind-mount /proc/thread-self/net over /proc/net in namespaces#5
Merged
fix: bind-mount /proc/thread-self/net over /proc/net in namespaces#5
Conversation
After setns(CLONE_NEWNET), /proc/net (a symlink to self/net) still resolves to the thread group leader's network namespace, not the calling thread's. Only /proc/thread-self/net reflects the new namespace. This caused libraries like netwatch that read /proc/net/route to get the host's default route interface (e.g. enp7s0) instead of the namespace's eth0, breaking socket binding after link flaps in iroh. Fix: always create a private mount namespace (CLONE_NEWNS) on every namespace thread and bind-mount /proc/thread-self/net over /proc/net. Also make the tokio blocking pool on_thread_start unconditional so spawned blocking threads get the same fix.
dignifiedquire
force-pushed
the
dig/fix-bind-mount
branch
from
dfb82af to
7895dde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After setns(CLONE_NEWNET), /proc/net (a symlink to self/net) still resolves to the thread group leader's network namespace, not the calling thread's. Only /proc/thread-self/net reflects the new namespace.
This caused libraries like netwatch that read /proc/net/route to get the host's default route interface (e.g. enp7s0) instead of the namespace's eth0, breaking socket binding after link flaps in iroh.
Fix: always create a private mount namespace (CLONE_NEWNS) on every namespace thread and bind-mount /proc/thread-self/net over /proc/net. Also make the tokio blocking pool on_thread_start unconditional so spawned blocking threads get the same fix.