This repository was archived by the owner on Nov 10, 2017. It is now read-only.
Conversation
Owner
Author
What a freaking Travis mess. |
Owner
Author
|
Seems related to brianmcd/contextify#180, which is marked as resolved. What a mess. |
n1k0
force-pushed
the
node-4+
branch
2 times, most recently
from
534e4d7 to
976ee2d
Compare
| scrape(url, {userAgent: userAgent}) | ||
| .catch(handleError) | ||
| .then(function(result) { | ||
| res.json(sanitize ? sanitizeResult(result) : result); |
Collaborator
There was a problem hiding this comment.
resullt can be undefined when the scrape() fails, since handleError() returns nothing
Owner
Author
There was a problem hiding this comment.
Hence the .catch next, but yeah I do see your point.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promise default rejection handling strategy seems to have been updated in recent nodejs versions. This patch updates the code accordingly.