Skip to content

Conversation

@jonathanio
Copy link
Contributor

Rename the service label to endpoint in order to avoid conflicts with pre-defined Prometheus labels, which is causing service to be renamed to exported_service.

Checklist

Before raising or requesting a review of the pull request, please check and confirm the following items have been performed, where possible:

  • I have performed a self-review of my code and run any tests locally to check
  • I have added tests that prove that any changes are effective and work correctly
  • I have made corresponding changes, as needed, to the repository documentation
  • Each commit in, and this pull request, have meaningful subjects and bodies for context
  • I have added release/..., type/..., and changes/... labels, as needed, to this pull request

Rename the service label to endpoint in order to avoid conflicts with
pre-defined Prometheus labels, which is causing service to be renamed to
exported_service.
@jonathanio jonathanio added priority/medium This is a medium-priority issue or pull request release/fix A fix for a bug or identified issue with this pull request type/bug Something is not working correctly update/go Update with changes to Go files or applications labels Aug 15, 2024
@jonathanio jonathanio self-assigned this Aug 15, 2024
@jonathanio jonathanio enabled auto-merge August 15, 2024 21:33
@codecov
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 9.70%. Comparing base (4b120e2) to head (606d606).
Report is 2 commits behind head on main.

Files Patch % Lines
internal/serve/middleware/prometheus.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #16   +/-   ##
=====================================
  Coverage   9.70%   9.70%           
=====================================
  Files         17      17           
  Lines        515     515           
=====================================
  Hits          50      50           
  Misses       465     465           
Flag Coverage Δ
unit-tests 9.70% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/serve/middleware/prometheus.go 0.00% <0.00%> (ø)

@jonathanio jonathanio merged commit 9979e55 into main Aug 15, 2024
@jonathanio jonathanio deleted the refactor-prometheus-metrics branch August 15, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/medium This is a medium-priority issue or pull request release/fix A fix for a bug or identified issue with this pull request type/bug Something is not working correctly update/go Update with changes to Go files or applications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants