Skip to content

Conversation

@jonathanio
Copy link
Contributor

Prepare for the setup of the clustering by adding configuration support for setting the cluster name. This will be used for logging, providing a differentiator, and for metrics. Additionally, re-rename the endpoint label to component in order to avoid conflicts with pre-defined Prometheus labels, which is causing endpoint to be renamed to exported_endpoint, just like with service.

Also, remove all references, and all configuration, including the StatefulSet support, for managing state and storage for the application as the app will be going in another direction.

Checklist

Before raising or requesting a review of the pull request, please check and confirm the following items have been performed, where possible:

  • I have performed a self-review of my code and run any tests locally to check
  • I have added tests that prove that any changes are effective and work correctly
  • I have made corresponding changes, as needed, to the repository documentation
  • Each commit in, and this pull request, have meaningful subjects and bodies for context
  • I have added release/..., type/..., and changes/... labels, as needed, to this pull request

Prepare for the setup of the clustering by adding configuration support
for setting the cluster name. This will be used for logging, providing a
differentiator, and for metrics. Additionally, re-rename the endpoint
label to component in order to avoid conflicts with pre-defined
Prometheus labels, which is causing endpoint to be renamed to
exported_endpoint, just like with service.
Remove all references, and all configuration, including the StatefulSet
support, for managing state and storage for the application as the app
will be going in another direction with nats.io and JetStream
potentially.
@jonathanio jonathanio added priority/normal This is a normal-priority issue or pull request release/update An update to an existing feature is made with this pull request update/go Update with changes to Go files or applications update/helm Update with changes to the Helm charts labels Aug 21, 2024
@jonathanio jonathanio self-assigned this Aug 21, 2024
@codecov
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 79 lines in your changes missing coverage. Please review.

Project coverage is 9.94%. Comparing base (f6b7f06) to head (228071a).
Report is 3 commits behind head on main.

Files Patch % Lines
internal/serve/metrics/healthz/main.go 0.00% 35 Missing ⚠️
internal/serve/metrics/main.go 0.00% 18 Missing ⚠️
internal/serve/web/main.go 0.00% 13 Missing ⚠️
internal/serve/middleware/prometheus.go 0.00% 8 Missing ⚠️
internal/cmd/serve.go 0.00% 4 Missing ⚠️
internal/logger/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #19      +/-   ##
========================================
+ Coverage   9.70%   9.94%   +0.23%     
========================================
  Files         17      16       -1     
  Lines        515     503      -12     
========================================
  Hits          50      50              
+ Misses       465     453      -12     
Flag Coverage Δ
unit-tests 9.94% <0.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/logger/main.go 0.00% <0.00%> (ø)
internal/cmd/serve.go 0.00% <0.00%> (ø)
internal/serve/middleware/prometheus.go 0.00% <0.00%> (ø)
internal/serve/web/main.go 0.00% <0.00%> (ø)
internal/serve/metrics/main.go 0.00% <0.00%> (ø)
internal/serve/metrics/healthz/main.go 0.00% <0.00%> (ø)

@jonathanio jonathanio merged commit 6349496 into main Aug 21, 2024
@jonathanio jonathanio deleted the refactor-prometheus-metrics branch August 21, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/normal This is a normal-priority issue or pull request release/update An update to an existing feature is made with this pull request update/go Update with changes to Go files or applications update/helm Update with changes to the Helm charts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants