Possible issues in getNodeWebhookPath when webhookId or path is undefined

[nourahaddaoui]

Bug Description

While exploring how getNodeWebhookPath works, I noticed that it might not handle cases well when webhookId or path is undefined.
This could lead to unexpected webhook paths being generated, which might cause errors or strange behavior when handling webhooks.

To Reproduce

1. Call getNodeWebhookPath without passing a webhookId or path, or pass undefined.
2. Check the resulting webhookPath.
3. See if the function breaks or returns something that doesn’t make sense.

Expected behavior

It would be better if the function could handle missing values more gracefully: maybe by throwing a clear error, returning a default, or avoiding bad webhook construction altogether.

Operating System

macOS Sonoma

n8n Version

1.90.2

Node.js Version

v20.18.0

Database

SQLite (default)

Execution mode

main (default)

[Joffcom]

Hey @nourahaddaoui,

We have created an internal ticket to look into this which we will be tracking as "GHC-1835"

[Joffcom]

Hey @nourahaddaoui

If this is a bug can you provide a way to reproduce it from a workflow?

[nourahaddaoui]

Hey, sure, here’s how you can reproduce the issue from a workflow:

1. Open or create a workflow in the n8n app that uses a webhook node.
2. Edit the node so that its webhookId is either missing or set to undefined.
3. Call the getNodeWebhookPath function with a valid workflowId, the edited node, and leave the path parameter undefined or missing.
4. Run the workflow (either manually or through the webhook).

Check the resulting webhookPath and watch for any errors or strange behavior during execution.
In my case, it didn’t throw a helpful error or fallback; it just built an incorrect path, which made webhook handling fail unexpectedly.

Hope this helps!

[janober]

Fix got released with n8n@1.102.0