fix(editor): Improve handling of trailing 'Trigger' in NodeCreator search #14612
Conversation
CharlieKolb
changed the title
|
|
||
| describe('sublimeSearch', () => { | ||
| const testCases = [{ filter: 'agent', expectedOrder: ['Magento 2', 'AI Agent'] }]; | ||
| describe('search finds at least one match', () => { |
There was a problem hiding this comment.
Was gonna introduce another set of exact test matches, but will do so in follow up. This intends (use Whitespace only for review) and drops the weight parameter
| filter: string, | ||
| data: Readonly<T[]>, | ||
| keys: Array<{ key: string; weight: number }>, | ||
| keys: Array<{ key: string; weight: number }> = DEFAULT_KEYS, |
There was a problem hiding this comment.
Since we only have one use case this seems preferred over duplicating it in the test. Also happy to instead provide the variable in both call sites
CharlieKolb
requested review from
a team and
autologie
and removed request for
a team
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
mrge found 1 issue across 4 files. View it in mrge.io
packages/frontend/editor-ui/src/components/Node/NodeCreator/utils.test.ts
Show resolved
Hide resolved
autologie
left a comment
autologie
left a comment
There was a problem hiding this comment.
My comments may not apply if the user input is already normalized elsewhere beforehand
packages/frontend/editor-ui/src/components/Node/NodeCreator/utils.test.ts
Show resolved
Hide resolved
|
✅ All Cypress E2E specs passed |
|
Got released with |
Summary
First step of getting things tidied up here. We improve the filtering of
triggerto only do so if trailing another word, and, while we're at it, update it to work for partial completion as wellRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3395/search-in-node-panel-doesnt-work-for-term-trigger
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)