fix(McpClientTool): Dereference input schema before converting to Zod #15757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where JSON schemas containing
$refreferences were not properly resolved before being converted to Zod schemas in the McpClientTool. This was causing validation errors when using schemas with$refdefinitions.Changes made:
$refreferences are properly resolved to their actual schema definitions#/definitions/...) and nested$refstructuresHow to test:
$reflike:{ "$schema": "http://json-schema.org/draft-07/schema#", "type": "object", "properties": { "user": { "$ref": "#/definitions/user" } }, "definitions": { "user": { "type": "object", "properties": { "name": { "type": "string" }, "age": { "type": "number" } } } } }$refand circular reference cases to ensure proper error handlingRelated Linear tickets, Github issues, and Community forum posts
Closes #15603
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)