Skip to content

Conversation

@r00gm
Copy link
Contributor

@r00gm r00gm commented Jun 5, 2025

Summary

Fix the error messages when an expression tries to access a node that is not connected to
image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/PAY-2653/paired-item-regression-when-referencing-unconnected-node

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@r00gm r00gm marked this pull request as ready for review June 5, 2025 11:48
@r00gm r00gm requested a review from elsmr June 5, 2025 11:48
@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

❌ Patch coverage is 76.10619% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/workflow/src/workflow-data-proxy.ts 56.45% 27 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 2 files and found no issues. Review PR in cubic.dev.

@r00gm r00gm changed the title fix: error when there is no path back to referenced node fix(editor): Fix error when there is no path back to referenced node Jun 5, 2025
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 5, 2025
elsmr
elsmr previously approved these changes Jun 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

OlegIvaniv
OlegIvaniv previously approved these changes Jun 11, 2025
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cstuncsik cstuncsik dismissed stale reviews from OlegIvaniv and elsmr via 8f6a051 July 21, 2025 08:33
@cstuncsik cstuncsik closed this Jul 21, 2025
@cstuncsik cstuncsik force-pushed the pay-2653-paired-item-regression-when-referencing-unconnected-node branch from 8f6a051 to 1159345 Compare July 21, 2025 08:34
@cstuncsik cstuncsik reopened this Jul 21, 2025
@currents-bot
Copy link

currents-bot bot commented Jul 21, 2025

E2E Tests: n8n tests passed after 5m 48.7s

🟢 521 · 🔴 0 · ⚪️ 1

View Run Details

Run Details

  • Project: n8n

  • Groups: 3

  • Framework: Playwright

  • Run Status: Passed

  • Commit: 295b00a

  • Spec files: 110

  • Overall tests: 522

  • Duration: 5m 48.7s

  • Parallelization: 3

Groups

GroupId Results Spec Files Progress
mode:standard - Parallel 🟢 9 · 🔴 0 · ⚪️ 1 3 / 3
mode:standard - Sequential 🟢 4 · 🔴 0 · ⚪️ 0 2 / 2
No name 🟢 508 · 🔴 0 · ⚪️ 0 105 / 105


This message was posted automatically by currents.dev | Integration Settings

…m-regression-when-referencing-unconnected-node
cstuncsik
cstuncsik previously approved these changes Jul 22, 2025
cstuncsik
cstuncsik previously approved these changes Jul 22, 2025
cstuncsik
cstuncsik previously approved these changes Jul 22, 2025
@cstuncsik cstuncsik merged commit d6ac924 into master Jul 22, 2025
17 checks passed
@cstuncsik cstuncsik deleted the pay-2653-paired-item-regression-when-referencing-unconnected-node branch July 22, 2025 08:04
elsmr pushed a commit that referenced this pull request Jul 25, 2025
This was referenced Jul 28, 2025
@janober
Copy link
Member

janober commented Jul 28, 2025

Got released with n8n@1.105.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants