chore(editor): Update format for showing execution time #16099
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 1 issue across 4 files. Review it in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
| const nodeType = activeNodeType ? this.shortNodeType(activeNodeType) : ''; // unused in eventTriggerDescription | ||
| const initialKey = `n8n-nodes-base.nodes.${nodeType}.nodeView`; | ||
| const shortNodeType = activeNodeType ? this.shortNodeType(activeNodeType) : ''; // unused in eventTriggerDescription | ||
| const initialKey = `n8n-nodes-base.nodes.${shortNodeType}.nodeView`; |
There was a problem hiding this comment.
Just fixing shadowed variable name
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
| expect(new I18nClass().displayTimer(1120, true)).toBe('1.12s'); | ||
| expect(new I18nClass().displayTimer(1234, true)).toBe('1.234s'); | ||
| expect(new I18nClass().displayTimer(600000, true)).toBe('10m 0s'); | ||
| expect(new I18nClass().displayTimer(601234, true)).toBe('10m 1.234s'); |
There was a problem hiding this comment.
Should not we handle ms separately here and follow the general pattern? As in 1s 1ms instead of 1.001s?
There was a problem hiding this comment.
This is a bit tricky, I think we want to keep 1.234s format in places like this:
There was a problem hiding this comment.
gotcha. Might be worth discussing with David where this should show fully or partial?
|
✅ All Cypress E2E specs passed |
|
Got released with |
Summary
This PR updates the format used for showing execution time in editor UI to make it more commonly used one
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/SUG-71/feature-adjust-time-formatting-to-xh-xm-xs-in-the-log-view
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)