feat(core): Dynamic max page size limit for pagination dto #16100
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 4 issues across 3 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
afitzek
left a comment
afitzek
left a comment
There was a problem hiding this comment.
Just an optional small comment, looks good otherwise 👍
|
|
||
| export class ListInsightsWorkflowQueryDto extends Z.class({ | ||
| ...paginationSchema, | ||
| skip: skipValidator, |
There was a problem hiding this comment.
Would it make sense to include the full paginationSchema and just overwrite the take validator? For example:
...paginationSchema,
take: createTakeValidator(MAX_ITEMS_PER_PAGE),
This way if the paginationSchema changes otherwise, we will automatically get these changes.
|
|
guillaumejacquart
force-pushed
the
pay-2924-insights-table-page-size-does-not-work
branch
from
ce8ac42 to
165e9d8
Compare
|
|
guillaumejacquart
force-pushed
the
pay-2924-insights-table-page-size-does-not-work
branch
from
165e9d8 to
572be8f
Compare
|
|
2 similar comments
|
|
|
|
|
✅ All Cypress E2E specs passed |
guillaumejacquart
deleted the
pay-2924-insights-table-page-size-does-not-work
branch
|
Got released with |
Summary
Make the max page size dynamic when parsing the pagination DTO, because insights require a max page size of 100.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2924/insights-table-page-size-does-not-work
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)