fix: broken link in v6 docs README for Nablarch 6u2 (#326)#331
Open
fix: broken link in v6 docs README for Nablarch 6u2 (#326)#331
Conversation
kiyotis
commented
May 7, 2026
Space in the filename broke Markdown link parsing — encoded as %20 so the link resolves correctly in GitHub and CommonMark renderers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
docs.py generated README.md with raw spaces in file paths; next create run would have reverted the manual %20 fix. quote() now encodes spaces permanently so links survive create/verify cycles. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Re-run of expert review requested by reviewer after source code changes (docs.py URL-encoding fix + test_docs.py TestReadmeUrlEncoding class). Both reviews: 0 Findings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
quote() encoded Japanese characters too, which would corrupt 161
existing valid Japanese paths across 5 README files on next create run.
Use str.replace(" ", "%20") to fix only the character that breaks
Markdown link parsing; other non-ASCII chars are valid GitHub link targets.
Added test_readme_does_not_encode_japanese_in_filename as regression guard.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kiyotis
force-pushed
the
326-fix-broken-link-readme
branch
from
a710d7e to
49d0a9c
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #326
Approach
The link target filename contained a literal space:
releases-nablarch6u2-releasenote-6u2 (6u1からの変更点).md. Markdown link parsers treat unencoded spaces as link terminators, so the link rendered as plain text. Fixed by URL-encoding the space as%20, which GitHub and CommonMark renderers correctly decode when resolving file paths.A horizontal scan of the README confirmed no other links contain unencoded spaces.
docs.pyalso fixed to encode spaces at create-time so the manual%20fix survives subsequent create/verify cycles. Initial fix usedurllib.parse.quote()which encoded Japanese characters too; narrowed tostr.replace(" ", "%20")to avoid corrupting the 161 existing Japanese paths across 5 README files.Tasks
See tasks.md.
Expert Review
AI-driven expert reviews conducted before PR creation (see
.claude/rules/expert-review.md):Success Criteria Check
.claude/skills/nabledge-6/docs/README.mdline 371: space encoded as%20docs.pyusesstr.replace(" ", "%20"); 18 unit tests pass🤖 Generated with Claude Code