Removed stdout flush for performance optimization, also fixes gitignore#23
Merged
Removed stdout flush for performance optimization, also fixes gitignore#23
Conversation
nacho
approved these changes
Oct 20, 2025
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the explicit flush from stdout as suggested by #22. In my case this didn't lead to noticeable performance improvements tbh... I will keep debugging/profiling and I start thinking that moving to a shared memory buffer or - even better - a cross-prcess dmabuf, is the way to go... but it's a larger change (the dmabuf would also save us the time spent in glReadPixel).
Anyway, this is a first step that won't hurt.