Added styling to navbar #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nafees87n
requested changes
Oct 9, 2021
Owner
nafees87n
left a comment
nafees87n
left a comment
There was a problem hiding this comment.
Thanks for another great PR. Added some minor suggestions.
Comment on lines
9
to
12
| import { FiClock } from "react-icons/fi"; | ||
| import { FiFileText } from "react-icons/fi"; | ||
| import { FiRotateCcw } from "react-icons/fi"; | ||
| import { FiAlignJustify } from "react-icons/fi"; |
Owner
There was a problem hiding this comment.
Suggested change
| import { FiClock } from "react-icons/fi"; | |
| import { FiFileText } from "react-icons/fi"; | |
| import { FiRotateCcw } from "react-icons/fi"; | |
| import { FiAlignJustify } from "react-icons/fi"; | |
| import { FiClock,FiFileText, FiRotateCcw, FiAlignJustify} from "react-icons/fi"; |
| import { FiFileText } from "react-icons/fi"; | ||
| import { FiRotateCcw } from "react-icons/fi"; | ||
| import { FiAlignJustify } from "react-icons/fi"; | ||
| import { ImBrightnessContrast } from "react-icons/im"; |
Owner
There was a problem hiding this comment.
We can remove ImBrightnessContrast as its not being used
Contributor
Author
|
@nafees87n, I have made the changes as asked. |
nafees87n
reviewed
Oct 9, 2021
| import AceEditor from 'react-ace' | ||
| import axios from 'axios' | ||
| import openSocket from 'socket.io-client' | ||
| import { AiFillGithub,FiClock,FiFileText,FiRotateCcw,FiAlignJustify } from "react-icons/ai"; |
Owner
There was a problem hiding this comment.
@kailash360 A mistake has been made here while refactoring. This line would throw an error. Please fix this.
Contributor
Author
There was a problem hiding this comment.
I have fixed this now. Sorry for the silly mistake 😅.
nafees87n
approved these changes
Oct 9, 2021
Owner
|
@kailash360 Merged the PR. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modified the navbar elements and added icons using react icons. This is PR for issue #16 .