Conversation
4 tasks
eskenazit
requested changes
Apr 13, 2026
Contributor
eskenazit
left a comment
eskenazit
left a comment
There was a problem hiding this comment.
minor thing : if the branch is chore, all commits are expected to be chores, otherwise the branch should be a feat/ or fix/ ;)
Contributor
Author
|
@eskenazit Coud you review again? Would you consider this PR a feature? I saw it as a refactoring, not adding any functional value, setting the technical stage for the other PR |
jlouvel
force-pushed
the
chore/mcp-restlet-transport
branch
from
22e64b2 to
9fdee47
Compare
Contributor
|
Definitely a chore in my book, so all commits messages should be chore =) |
Removed a few outdated blueprints
Migrate the MCP server adapter from raw Jetty Handler.Abstract to the Restlet ServerResource pattern, unifying all exposes adapters on the same HTTP transport layer. - Create McpServerResource (Restlet ServerResource for MCP Streamable HTTP) - Rewrite McpServerAdapter.initHttpTransport to use Restlet Server/Router - Pull shared Server lifecycle into ServerAdapter base class (initServer, getServer, start, stop) and simplify REST, Skill, and MCP adapters - Remove JettyStreamableHandler and its test - Add McpServerResourceTest with 8 focused tests (GET 405, empty body, malformed JSON, initialize session, notifications 202, DELETE with/without session, unknown RPC method, bad JSON-RPC version) - Remove jetty-server and jetty-http2-common dependencies from pom.xml
eskenazit
force-pushed
the
chore/mcp-restlet-transport
branch
from
9fdee47 to
ba484fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates the MCP server adapter HTTP transport from raw Jetty
Handler.Abstractto the RestletServerResourcepattern, unifying all exposes adapters (REST, Skill, MCP) on the same transport layer.Key changes:
McpServerResource— new RestletServerResourceimplementing POST (JSON-RPC dispatch), DELETE (session termination), and GET (405 rejection)McpServerAdapter—initHttpTransport()now usesorg.restlet.Server+Routerinstead of JettyServer+ServerConnectorServerAdapter— factored the common RestletServerlifecycle (initServer,getServer,start,stop) into the base class, removing duplication across REST, Skill, and MCP adaptersJettyStreamableHandler,JettyStreamableHandlerTest, andjetty-server/jetty-http2-commondependencies frompom.xmlNo protocol changes —
ProtocolDispatcher,ToolHandler,ResourceHandler,PromptHandler, andStdioJsonRpcHandlerare untouched.Tests
McpServerResourceTest(new, 8 tests) — GET returns 405, empty body returns parse error, malformed JSON returns parse error, initialize returnsMcp-Session-Idheader,notifications/initializedreturns 202, DELETE with session returns 200, DELETE without session returns 200, unknown RPC method returns -32601, bad JSON-RPC version returns -32600Checklist
mainAgent Context (optional)