Conversation
Contributor
|
It seems this branch has way too much files for just a fix, it looks like this branch was rebased from Let us discuss branch management and rules to avoid that in the future =) |
0f0278c to
58a73aa
Compare
58a73aa to
d10b80a
Compare
Contributor
Author
|
@eskenazit There was no need to initially create this PR based on the mcp-auth one. I've rebased on main to it only has the 2 useful commits in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #212
What does this PR do?
When an
apikeyauthentication spec omits theplacementfield,HttpClientAdapter.setChallengeResponse()threw aNullPointerExceptiononplacement.equals("header").This PR adds a null guard that throws a clear
IllegalArgumentExceptionwith the message"placement is required for apikey authentication (expected: header or query)".Tests
Added
setChallengeResponseShouldThrowWhenApiKeyPlacementIsMissinginHttpClientAdapterTest— verifies the exception type and message whenplacementis omitted.Checklist
mainAgent Context (optional)