-
Notifications
You must be signed in to change notification settings - Fork 298
Open
Labels
Description
It seems that the content of no_proxy are somewhat arbitrary. The W3C reference states that's it's just domains but that's in the context of Mosaic. Supporting static IP addresses only is too limiting.
Our corporate no_proxy environment variable takes the form of 192.168.*,*.ourdomain.com but httpclient doesn't understand the * and so connections still go through the proxy.
A quick change is to change line 540 of httpclient.rb to replace * with .+
regexp = /(\A|\.)#{Regexp.quote(host).gsub('\*', '.+')}\z/iSupport for CIDR format might also be useful / an alternative (192.168.0.0/16)
I see that #110 also requested a change to no_proxy that didn't progress.