Murisi/unsafe conversion deserialization#96
Merged
tzemanovic merged 3 commits intomainfrom Mar 20, 2025
Merged
Conversation
batconjurer
approved these changes
Mar 19, 2025
grarco
approved these changes
Mar 20, 2025
0337143 to
24bdc9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the functionality to deserialize
AllowedConversions without checking that the deserialized generators correspond to the deserialized value sums. This unchecked functionality is required because it can sometimes be much faster to compute a set ofAllowedConversions using homomorphic operations (like elliptic curve point additions, subtractions, and negations) than it is to independently check that eachAllowedConversionis correct. This is because independent checks use expensive elliptic curve point multiplications.